we should migrate old configs to new, since domain is just a multiaddr, we can easily move it to address as a single entry vec. Also note that domain was migrated out of provider config and into server config

we should migrate old configs to new, since domain is just a multiaddr, we can easily move it to address as a single entry vec. Also note that domain was migrated out of provider config and into server config

can you elaborate, what old vs new?

can you elaborate, what old vs new?

For nodes properly setup with a domain, they'd already have something configured like

[server_config]
domain = "/dns/foo.bar/" # recently migrated out of provider_config since its specific to the entire node
port = 4069
addr = "0.0.0.0"
...

Since the new provider_config.addresses is just a vector of addresses to use for the announcement, we could reuse the domain value configured already right?

can you elaborate, what old vs new?

For nodes properly setup with a domain, they'd already have something configured like

[server_config]
domain = "/dns/foo.bar/" # recently migrated out of provider_config since its specific to the entire node
...

Since the new provider_config.addresses is just a vector of addresses to use for the announcement, we could reuse the domain value configured already right?

they would need to move to using IP addresses

Looks good. I was talking with @theBeardA about which port number the gateway should use. If we plan to always encrypt the connection between gateway and node (I think, correct me if im wrong please) using HTTPS, 443 is a good default. If the port will not be advertised anymore, we should update the gateway here https://github.com/fleek-network/ursa/blob/main/crates/ursa-gateway/src/resolver/mod.rs#L124.